Skip to content

feat: Migrate biorad_bioplex_manager to use SeriesData.get_unread - #1100

Merged
oscar-castro-bl merged 6 commits into
mainfrom
biorad_bioplex_manager_get_unread
Nov 12, 2025
Merged

feat: Migrate biorad_bioplex_manager to use SeriesData.get_unread#1100
oscar-castro-bl merged 6 commits into
mainfrom
biorad_bioplex_manager_get_unread

Conversation

@oscar-castro-bl

Copy link
Copy Markdown
Collaborator

No description provided.

@oscar-castro-bl
oscar-castro-bl requested review from a team and slopez-b as code owners October 8, 2025 21:13
@oscar-castro-bl
oscar-castro-bl requested review from ajcariaga16 and james-leinas and removed request for ajcariaga16 October 8, 2025 21:13
@nathan-stender

Copy link
Copy Markdown
Collaborator

@slopez-b @joshua-benchling can I get a first pass from one of you on this PR?

@joshua-benchling joshua-benchling left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting warnings still

Image

Comment thread src/allotropy/parsers/biorad_bioplex_manager/biorad_bioplex_manager_structure.py Outdated

@nathan-stender nathan-stender left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to remove my review - please re-request after @joshua-benchling approves

@oscar-castro-bl

Copy link
Copy Markdown
Collaborator Author

I am getting warnings still

Image

Unread warnings were addressed.

@oscar-castro-bl
oscar-castro-bl merged commit cca387f into main Nov 12, 2025
7 checks passed
@oscar-castro-bl
oscar-castro-bl deleted the biorad_bioplex_manager_get_unread branch November 12, 2025 15:55
nathan-stender added a commit that referenced this pull request Nov 19, 2025
### Added

- JSON-to-CSV - improve list parsing to better support datacubes (#1124)
- Cytiva Biacore T200 control - add unread data (#1120)
- Qiacuity dPCR - Added unread data (#1103)
- Migrate biorad_bioplex_manager to use SeriesData.get_unread (#1100)
- Mass spectrometer ASM schema (#1121)
- Roche Cedex BioHT - Add support for mM unit (mmol/L) (#1119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants